fix: cache value & cancel tween for instant-set #4847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4846
Now when the early-out branch is taken for a
duration
of 0 it will do two things that were missing in the first implementation:value
correctly, so that later tweens use the correct starting point.Is there a better way to test this within the current suite? The mocha tests don't have access to any browser globals so you can't actually test any tweens and given how broken this was after #4766 the lack of test coverage makes me nervous.
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)